LTI-388, LTI-389, LTI-390: improvements and fixes to param forwarding #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ata to BBB with shared rooms
jfederico
reviewed
Jun 26, 2024
Mariam05
changed the title
Mariam05
changed the title
jfederico
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LTI-388: Looks for the parameters in the entire launch params hierarchy, rather than just the custom_params nested hash.
LTI-389: Stops storing the params to be sent to BBB in the room's settings column, but rather stores them in an instance variable.
LTI-390: This PR also fixes the issue in which the wrong data is sent to BBB when using shared rooms